-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UART and TWIM: Implement large buffer splitting and check for readonly buffers in flash #50
Conversation
d19f616
to
e954598
Compare
e954598
to
91f94e8
Compare
@jamesmunns / @hannobraun / @Yatekii Should we try to do something about this change? This patch includes the fail-if-DMA is not in RAM check and replaces the 255 limit on easy DMA by splitting it up in several if there is a limit. |
Sorry, I don't have time to take a closer look right now. I've added it to my list. |
@simonsso I tried to speed up discussions about the implicit copy and batching. Maybe it should be merged for now and adapted later on (even tho I think we'll never adapt it then :P). What do you think about this @jamesmunns @hannobraun? Appart from the ongoing issue about implicity, this seems to be sound otherwise (except for the minor issue pointed out by @somemetricprefix which can be fixed easily.). |
Same type of changes as done for SPI.
I have not split up the dma transfer for: pub fn write_then_read()
it is not clear to me what assumptions can be made about read and write - for instance if a write and read always completes in sync or if all writes shall be done before data starts to be revived.
There have been no attempts to verify this change -- other than it is almost the same as I did for SPI.