Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport changes made to nrf52-hal after split #6

Merged
merged 2 commits into from
Sep 13, 2018
Merged

Backport changes made to nrf52-hal after split #6

merged 2 commits into from
Sep 13, 2018

Conversation

hannobraun
Copy link
Contributor

Includes:

@wez I guess it makes more sense to merge #5 first, but I wanted to open this now so I don't forget.

@hannobraun
Copy link
Contributor Author

Travis fails. I'll take care of it later. After #5 is merged I'll have to rebase anyway.

The product specification refers to single-digit pins as P0.00, P0.01,
etc.
@hannobraun
Copy link
Contributor Author

Rebased, fixed up, and ready for review!

Copy link
Member

@jamesmunns jamesmunns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hannobraun
Copy link
Contributor Author

Thanks for the review, @jamesmunns!

@hannobraun hannobraun merged commit fd13c5a into nrf-rs:master Sep 13, 2018
@hannobraun hannobraun deleted the backport branch September 13, 2018 12:48
hargoniX pushed a commit to hargoniX/nrf-hal that referenced this pull request Jul 28, 2021
update README, add more reading links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants