Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix setting of the interactive env var #15084

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Feb 17, 2023

Current Behavior

The if statement for setting interactive for the CLI was mishandling undefined env var

Expected Behavior

We should only force set interactive to true when the env var is set

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Feb 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 17, 2023 at 4:43PM (UTC)

Co-authored-by: Craigory Coppola <craigorycoppola@gmail.com>
@Coly010 Coly010 merged commit 2a76e20 into nrwl:master Feb 17, 2023
@Coly010 Coly010 deleted the angular/fix-interactive-prompt branch February 17, 2023 17:31
FrozenPandaz pushed a commit that referenced this pull request Feb 17, 2023
Co-authored-by: Craigory Coppola <craigorycoppola@gmail.com>
(cherry picked from commit 2a76e20)
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants