fix(devkit): fix extractLayoutDirectory typescript types to better reflect allowed params and return value

[kdawgwilk]

In other projects with more strict TS settings the types on the extractLayoutDirectory did not line up with the allowed params and return value. Example of this I found is in the @nrwl/react package that calls this function with options.directory which is string | undefined which I am not sure why TS is not complaining about this 🤔

nx/packages/react/src/generators/library/lib/normalize-options.ts

Lines 20 to 22 in b87f838

	const { projectDirectory, layoutDirectory } = extractLayoutDirectory(
	options.directory
	);

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nx-dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 29, 2024 5:29pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b475264. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

🟥 Failed Commands
nx affected --target=e2e --base=c9244d253634a0ddd6f8091857e70c5f9cee0de9 --head=b47526498ceccbf59a9730076407008a09d0efcd --exclude=e2e-storybook,e2e-storybook-angular --parallel=1

✅ Successfully ran 7 targets

• nx run-many -t e2e-macos --parallel=1 --exclude=e2e-detox
• nx affected --target=test --base=c9244d253634a0ddd6f8091857e70c5f9cee0de9 --head=b47526498ceccbf59a9730076407008a09d0efcd --parallel=1
• nx affected --target=build --base=c9244d253634a0ddd6f8091857e70c5f9cee0de9 --head=b47526498ceccbf59a9730076407008a09d0efcd --parallel=3
• nx run-many -t root-lint check-imports check-commit check-lock-files depcheck --parallel=1 --no-dte
• nx affected --target=lint --base=c9244d253634a0ddd6f8091857e70c5f9cee0de9 --head=b47526498ceccbf59a9730076407008a09d0efcd --parallel=3
• nx-cloud record -- nx format:check --base=c9244d253634a0ddd6f8091857e70c5f9cee0de9 --head=b47526498ceccbf59a9730076407008a09d0efcd
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[kdawgwilk]

any tips on looking into the build failures? 47min of build logs to parse through to figure out why its failing doesn't sound super enjoyable 😅

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ddbf2d3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 6 targets

• nx affected --target=e2e --base=5369f5d52754253412f90baabaf832c78d98bae7 --head=ddbf2d3d8ef44d15e27d06393eee5e49aff10626 --parallel=1
• nx affected --targets=lint,test,build --base=5369f5d52754253412f90baabaf832c78d98bae7 --head=ddbf2d3d8ef44d15e27d06393eee5e49aff10626 --parallel=3
• nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• nx-cloud record -- nx format:check --base=5369f5d52754253412f90baabaf832c78d98bae7 --head=ddbf2d3d8ef44d15e27d06393eee5e49aff10626
• nx documentation --no-dte
• nx affected -t e2e-macos --parallel=1 --base=5369f5d52754253412f90baabaf832c78d98bae7 --head=ddbf2d3d8ef44d15e27d06393eee5e49aff10626

---

Sent with 💌 from NxCloud.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.