-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): resolve some strip-source-code bugs #15840
fix(core): resolve some strip-source-code bugs #15840
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ccbe804
to
2a63753
Compare
2a63753
to
e758a55
Compare
e758a55
to
fc9e356
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thank you so much for looking into this. 🎉
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
I found some bugs, added some test cases, and used my knowledge of js parsing quirks around template and regex literals to resolve them.
The regex handling was adapted from https://github.com/Microsoft/typescript/blob/2c952fe8505fc427cdfe30ed4b40343f0f5f39bc/src/services/classifier.ts#L260
Current Behavior
Imports after a template literal with 2 variables are not analyzed
Expected Behavior
These imports should be included in the dependency graph
Related Issue(s)
Fixes #