Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): deprecate styl from react and next for 17 #16135

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

xiongemi
Copy link
Collaborator

@xiongemi xiongemi commented Apr 5, 2023

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Apr 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2023 2:58pm

},
{
"value": "styl",
"label": "DEPRECATED: Stylus(.styl) [ http://stylus-lang.com ]"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The [ bracket should be aligned with the other options. Maybe this is better:

Stylus(.styl) [ http://stylus-lang.com ] (DEPRECATED)

Copy link
Member

@AgentEnder AgentEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create-nx-workspace looks good

@xiongemi xiongemi requested a review from jaysoo April 11, 2023 21:56
@jaysoo jaysoo merged commit 3eede1c into master Apr 12, 2023
@jaysoo jaysoo deleted the feat/deprecated-styl-react branch April 12, 2023 12:23
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants