fix(core): do not mix UNIX and performance API timestamps in profiles #18497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`TaskProfilingLifeCycle` calculates profile timestamps and durations based on a mix of performance timestamps (coming from `performance.now()`) and UNIX ones (coming from tasks). The problem comes when the two types of values are mixed - e.g. `perfStart` comes from the task and `perfEnd` comes from the performance API, or vice-versa. Since performance timestamps are relative to the process start and UNIX timestamps are relative to the UNIX epoch, such cases would result in wrong calculations - e.g. an enormous negative value if `perfStart` is a UNIX timestamps and `perfEnd` is a performance timestamp. Closes nrwl#18388
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey @hristozov 👋, thanks for the PR. I've discussed this with @barbados-clemens and determined that we should go the other way. This implementation misses some specifics when batch mode is enabled. Can you try out #18595 and make sure it resolves the issue for you? |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
TaskProfilingLifeCyclecalculates profile timestamps and durations based on a mix of performance timestamps (coming fromperformance.now()) and UNIX ones (coming from tasks).The problem comes when the two types of values are mixed - e.g.
perfStartcomes from the task andperfEndcomes from the performance API, or vice-versa. Since performance timestamps are relative to the process start and UNIX timestamps are relative to the UNIX epoch, such cases would result in wrong calculations - e.g. an enormous negative value ifperfStartis a UNIX timestamps andperfEndis a performance timestamp.Expected Behavior
TaskProfilingLifeCycleshould produce profiles with correct durations.Change overview
Do not store UNIX timestamps at all. Instead, use only performance ones for the calculations.
Related Issue(s)
Fixes #18388