fix(js): esbuild should not throw when a project depends on non-js dependencies #19057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
AgentEnder
force-pushed
the
fix/js/dont-throw-if-depending-on-monodon-deps
branch
from
4020a55
to
e297be2
Compare
FrozenPandaz
approved these changes
Sep 7, 2023
| function isWorkspaceProject( | ||
| node: ProjectGraphProjectNode | ProjectGraphExternalNode, | ||
| graph: ProjectGraph | ||
| ): node is ProjectGraphExternalNode { |
There was a problem hiding this comment.
This is incorrect.
Suggested change
| ): node is ProjectGraphExternalNode { | |
| ): node is ProjectGraphProjectNode { |
AgentEnder
force-pushed
the
fix/js/dont-throw-if-depending-on-monodon-deps
branch
from
e297be2
to
75659e5
Compare
jaysoo
approved these changes
Sep 7, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
If a community plugin adds external nodes with a type outside of "npm" the esbuild executor tries to add them as external nodes to package.json. This results in build time failures.
Expected Behavior
We validate that the nodes represent workspace projects before we attempt to add them to the package.json
Related Issue(s)
Fixes #19043