Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(misc): remove usages of @nx/cypress:cypress-project internally #19766

Merged

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Oct 20, 2023

Replace with call to @nx/cypress:configuration, consistent with how we setup Playwright projects for apps. The deprecated generator will be removed in Nx 18.

Changes

  • Internal usage of @nx/cypress:cypress-project generator has been replaced with addProjectConfiguration + @nx/cypress:configuration
  • @nx/storybook:cypress-project generator updated to support projectNameAndRootFormat -- this was missed previously
  • The default tsconfig.json file for the e2e project has a different include config. Previously, we scoped to src/**/*.ts, but now it is **/*.ts, and we also include JSX files for React/Vue.

Follow-up

  • The @nx/cypress:configuration generator does not support as-provided paths, so we need a follow-up PR to address this issue.
  • The Angular e2e migrator uses the deprecated generator as well, but it isn't as straight-forward so we need to update this PR or have a follow-up PR to update it.

@vercel
Copy link

vercel bot commented Oct 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Oct 24, 2023 8:51pm

@jaysoo jaysoo force-pushed the feat/remove-deprecated-cypress-generator-internally branch from aa55e67 to 334bd04 Compare October 20, 2023 18:02
@jaysoo jaysoo requested a review from a team as a code owner October 20, 2023 18:02
@jaysoo jaysoo requested a review from meeroslav October 20, 2023 18:02
@jaysoo jaysoo force-pushed the feat/remove-deprecated-cypress-generator-internally branch from 334bd04 to 2f5adb2 Compare October 23, 2023 14:58
Copy link
Member

@AgentEnder AgentEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files I own (under /cypress or /web) look good.

packages/cypress/index.ts Outdated Show resolved Hide resolved
packages/cypress/index.ts Outdated Show resolved Hide resolved
@leosvelperez
Copy link
Member

PR updating the Angular e2e migrator: #19816.

@jaysoo jaysoo force-pushed the feat/remove-deprecated-cypress-generator-internally branch from 4502206 to 2603b93 Compare October 24, 2023 17:01
@jaysoo jaysoo force-pushed the feat/remove-deprecated-cypress-generator-internally branch from 2603b93 to e471dd9 Compare October 24, 2023 20:20
Replace with call to `@nx/cypress:configuration`. The deprecated
generator will be removed in Nx 18.
@jaysoo jaysoo force-pushed the feat/remove-deprecated-cypress-generator-internally branch from 76de8e4 to 22f9ccb Compare October 24, 2023 20:45
@jaysoo jaysoo merged commit b5ed979 into nrwl:master Oct 25, 2023
6 checks passed
@jaysoo jaysoo deleted the feat/remove-deprecated-cypress-generator-internally branch October 25, 2023 01:06
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants