-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(misc): remove usages of @nx/cypress:cypress-project internally #19766
feat(misc): remove usages of @nx/cypress:cypress-project internally #19766
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 22f9ccb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
aa55e67
to
334bd04
Compare
334bd04
to
2f5adb2
Compare
packages/angular/src/generators/application/__snapshots__/application.spec.ts.snap
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Files I own (under /cypress or /web) look good.
PR updating the Angular e2e migrator: #19816. |
2f5adb2
to
4502206
Compare
4502206
to
2603b93
Compare
2603b93
to
e471dd9
Compare
e471dd9
to
76de8e4
Compare
Replace with call to `@nx/cypress:configuration`. The deprecated generator will be removed in Nx 18.
76de8e4
to
22f9ccb
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Replace with call to
@nx/cypress:configuration
, consistent with how we setup Playwright projects for apps. The deprecated generator will be removed in Nx 18.Changes
@nx/cypress:cypress-project
generator has been replaced withaddProjectConfiguration
+@nx/cypress:configuration
@nx/storybook:cypress-project
generator updated to supportprojectNameAndRootFormat
-- this was missed previouslytsconfig.json
file for the e2e project has a differentinclude
config. Previously, we scoped tosrc/**/*.ts
, but now it is**/*.ts
, and we also include JSX files for React/Vue.Follow-up
@nx/cypress:configuration
generator does not supportas-provided
paths, so we need a follow-up PR to address this issue.