Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): resolve generator collections when generating a extended schematic #19815

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Oct 24, 2023

Current Behavior

When generating a schematic through a generator collection that extends from the schematic collection, the generation fails. The Angular DevKit fails when trying to load the generator collection because it looks for a schematics entry in the package.json.

Expected Behavior

Generating a schematic through a generator collection that extends from the schematic collection should work as expected.

Related Issue(s)

Fixes #19786

@leosvelperez leosvelperez self-assigned this Oct 24, 2023
@vercel
Copy link

vercel bot commented Oct 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2023 1:08pm

@leosvelperez leosvelperez marked this pull request as ready for review October 24, 2023 10:19
@leosvelperez leosvelperez requested a review from a team as a code owner October 24, 2023 10:19
@leosvelperez leosvelperez marked this pull request as draft October 24, 2023 12:17
@leosvelperez leosvelperez marked this pull request as ready for review October 24, 2023 13:08
@leosvelperez leosvelperez merged commit 5552b3b into nrwl:master Oct 25, 2023
6 checks passed
@leosvelperez leosvelperez deleted the core/fix-schematics-support branch October 25, 2023 13:08
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when trying to create an Angular service with Nx generator
3 participants