feat(testing): allow cypress preset to execute a command for a web server #20355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 3f86a19. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
FrozenPandaz
force-pushed
the
cypress-ipc
branch
6 times, most recently
from
9c982d5
to
cd34fc4
Compare
FrozenPandaz
force-pushed
the
cypress-ipc
branch
from
cd34fc4
to
c1e58db
Compare
FrozenPandaz
force-pushed
the
cypress-ipc
branch
5 times, most recently
from
92a84f5
to
536d372
Compare
mandarini
approved these changes
Nov 27, 2023
This was referenced Nov 27, 2023
FrozenPandaz
force-pushed
the
cypress-ipc
branch
2 times, most recently
from
4decf1e
to
f089ad0
Compare
FrozenPandaz
force-pushed
the
cypress-ipc
branch
from
f089ad0
to
3f86a19
Compare
AgentEnder
approved these changes
Nov 27, 2023
jaysoo
approved these changes
Nov 27, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Cypress preset executes an executor for a target. This limits it to being used for nx targets. Also, executors are run directly without ensuring its task dependencies have been run.
Expected Behavior
Cypress preset executes a command. This allows it to be used for any command. Now if it's an nx command, the task dependencies will be run.
Related Issue(s)
Fixes #