Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix performance regression from using projects for loading… #20363

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

FrozenPandaz
Copy link
Collaborator

… plugins

Current Behavior

We always load projects to resolve plugins.. even when there are no plugins... or all plugins are resolvable without projects.

Expected Behavior

We only load projects if there are plugins which are not able to be resolved without projects

Related Issue(s)

Fixes #

Copy link

vercel bot commented Nov 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Nov 21, 2023 9:50pm

@FrozenPandaz FrozenPandaz marked this pull request as ready for review November 21, 2023 21:49
@FrozenPandaz FrozenPandaz requested a review from a team as a code owner November 21, 2023 21:49
@FrozenPandaz FrozenPandaz enabled auto-merge (squash) November 21, 2023 21:50
@FrozenPandaz FrozenPandaz merged commit 3a9c8e8 into nrwl:master Nov 22, 2023
6 checks passed
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants