fix(core): programmatic release API should throw on error #20448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f0dcb9a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 5 targets
Sent with 💌 from NxCloud. |
FrozenPandaz
approved these changes
Nov 28, 2023
fahslaj
approved these changes
Nov 28, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE TO REVIEWERS: The diff looks bigger than it is because removing
handeErrorscauses indentation changes, best to view with whitespace hidden: https://github.com/nrwl/nx/pull/20448/files?diff=unified&w=1Current Behavior
The functions were originally written as CLI command handlers and still behave too much like that when it comes to error handling. Consumers of the programmatic API do not get to use try/catch how they would expect to and do not get access to the raw errors.
Expected Behavior
Consumers of the programmatic API can use try/catch how they would expect to and get full access to the raw errors thrown by the command implementations.