Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): fix --first-release with conventional commits and independent projects #21320

Merged
merged 4 commits into from
Jan 25, 2024

Conversation

fahslaj
Copy link
Contributor

@fahslaj fahslaj commented Jan 25, 2024

Current Behavior

  • nx release tries to commit changes when there are changed files on disk, but no staged changes. This causes the commit git operation to error.
  • nx release --first-release fails on the first release for a repo configured with conventionalCommits: true and independent projects relationship. (The command still assumes a previous git tag exists)

Expected Behavior

  • nx release does not try to commit changes when there are no staged changes, regardless of other changes on disk.
  • nx release --first-release indicates to the version generator that it should not assume a previous git tag exists. Instead, the first git commit in the repo is used, which is consistent with the changelog behavior on the first release.

Copy link

vercel bot commented Jan 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jan 25, 2024 5:01am

@fahslaj fahslaj changed the title fix(release): fixes --first-release with conventional commits and independent projects fix(release): fix --first-release with conventional commits and independent projects Jan 25, 2024
@JamesHenry JamesHenry merged commit fc30d1b into nrwl:master Jan 25, 2024
6 checks passed
@fahslaj fahslaj deleted the fix/no-changes branch January 25, 2024 13:54
isaacplmann pushed a commit that referenced this pull request Jan 26, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants