fix(release): fix --first-release with conventional commits and independent projects #21320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fahslaj
changed the title
☁️ Nx Cloud ReportCI is running/has finished running commands for commit ff3c89c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
fahslaj
force-pushed
the
fix/no-changes
branch
from
f6b18b1
to
2c31b92
Compare
JamesHenry
approved these changes
Jan 25, 2024
isaacplmann
pushed a commit
that referenced
this pull request
Jan 26, 2024
…endent projects (#21320)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
nx releasetries to commit changes when there are changed files on disk, but no staged changes. This causes the commit git operation to error.nx release --first-releasefails on the first release for a repo configured with conventionalCommits: true and independent projects relationship. (The command still assumes a previous git tag exists)Expected Behavior
nx releasedoes not try to commit changes when there are no staged changes, regardless of other changes on disk.nx release --first-releaseindicates to the version generator that it should not assume a previous git tag exists. Instead, the first git commit in the repo is used, which is consistent with the changelog behavior on the first release.