fix(core): handle undefined properties in schemas with additionalProperties

[MaxKless]

fixes #22349

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated (UTC)
nx-dev	⬜️ Ignored (Inspect)	Visit Preview	Mar 27, 2024 10:04am

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e921535. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 6 targets

• nx affected --targets=e2e,e2e-ci --base=f839ed14c062cac7a13415659299e034ff400eec --head=e9215353112054533f8d7b701ff2049c33c0dbc9 --parallel=1
• nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• nx affected --targets=lint,test,build --base=f839ed14c062cac7a13415659299e034ff400eec --head=e9215353112054533f8d7b701ff2049c33c0dbc9 --parallel=3
• nx-cloud record -- nx format:check --base=f839ed14c062cac7a13415659299e034ff400eec --head=e9215353112054533f8d7b701ff2049c33c0dbc9
• nx documentation --no-dte
• nx affected -t e2e-macos --parallel=1 --base=f839ed14c062cac7a13415659299e034ff400eec --head=e9215353112054533f8d7b701ff2049c33c0dbc9

---

Sent with 💌 from NxCloud.

[robertIsaac]

thanks for the fix :)

[noelsoong]

i don't like the idea of using the nullish operator and giving it a default empty object.

i think the schema.additionalProperties !== undefined could be changed to

schema.additionalProperties != null

[noelsoong]

nvm addditionalProperties is not .properties carry on XD

[mattfysh]

This does prevent the error from appearing, but I think there is a larger issue at play here because after applying this fix the property that was triggering this error is still ignored. To reproduce:

npx create-nx-workspace@latest xyz \
  --workspaceType integrated --ci skip --preset ts --packageManager pnpm
cd xyz
nx g lib foo --bundler=none --unit-test-runner=none

foo/project.json

"printenv": {
      "executor": "nx:run-commands",
      "options": {
        "command": "env",
        "env": {
          "ONE": "TWO"
        }
      }
    },

Without this fix applied, you'll see the Cannot convert undefined or null to object

After applying the fix, the error no longer appears, but the property that triggered the error (env) is not applied to the task. You can see the ONE env var is missing in the logged output

[MaxKless]

thanks @mattfysh for the catch & the repro. Super helpful!
It's an unrelated issue but I fixed it and added it to the PR :)

[robertIsaac]

hi @FrozenPandaz
do you plan to publish it as a bugfix for nx 18.1?

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.