Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devkit): executor-to-plugin-migrator should add // targets hint #23167

Merged
merged 1 commit into from
May 3, 2024

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented May 3, 2024

Current Behavior

When convert-to-inferred generators are run, they leave no hints as to what happened to the targets.
This is usually fine as the person running the generator should know what it is doing.
However, other team members who may not have been privy to the migration may be confused when they see an empty project.json

Expected Behavior

Add the same // targets hint that we generate for plugin-first projects to help guide users to the PDV to see the targets.

Related Issue(s)

Fixes #

@Coly010 Coly010 requested review from a team as code owners May 3, 2024 14:17
@Coly010 Coly010 requested a review from AgentEnder May 3, 2024 14:17
@Coly010 Coly010 self-assigned this May 3, 2024
Copy link

vercel bot commented May 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview May 3, 2024 2:19pm

@Coly010 Coly010 enabled auto-merge (squash) May 3, 2024 14:20
@Coly010 Coly010 merged commit 2526979 into master May 3, 2024
6 checks passed
@Coly010 Coly010 deleted the convert-to-inferred-hint branch May 3, 2024 15:27
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants