chore(repo): refactor publish.yml for PR releases #26509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JamesHenry
force-pushed
the
pr-release-jh
branch
from
5ed94ec
to
fc58ca8
Compare
JamesHenry
changed the title
7 tasks
JamesHenry
force-pushed
the
pr-release-jh
branch
from
774a662
to
e8916a3
Compare
JamesHenry
force-pushed
the
pr-release-jh
branch
from
0abdfc4
to
196a918
Compare
JamesHenry
commented
Jun 12, 2024
JamesHenry
commented
Jun 12, 2024
JamesHenry
requested review from
a team,
FrozenPandaz,
isaacplmann,
vsavkin,
AgentEnder and
jaysoo
as code owners
isaacplmann
approved these changes
Jun 13, 2024
FrozenPandaz
approved these changes
Jun 13, 2024
FrozenPandaz
added a commit
that referenced
this pull request
Jun 13, 2024
This reverts commit 3750366.
FrozenPandaz
added a commit
that referenced
this pull request
Jun 13, 2024
This reverts commit 3750366.
FrozenPandaz
pushed a commit
that referenced
this pull request
Jun 14, 2024
Redo of #26509, with more guards for unexpected missing/relative values within full releases in GitHub Actions. --- Refactors our publish workflow to support PR releases, in addition to our previous triggers. **Tests:** --- - Example of failure on non-PR release (comment skipped): https://github.com/nrwl/nx/actions/runs/9480869812 --- - Example of failure on PR release (comment created on PR): - https://github.com/nrwl/nx/actions/runs/9480852880 - #26515 (comment) --- - Example of dry-run of full release (`workflow_dispatch` with no PR number provided): https://github.com/nrwl/nx/actions/runs/9497871483 --- - Real PR release created here: | Release details | 📑 | | ------------- | ------------- | | **Published version** | [0.0.0-pr-26515-856ef7f](https://www.npmjs.com/package/nx/v/0.0.0-pr-26515-856ef7f) | | **Triggered by** | @JamesHenry | | **Branch** | [JamesHenry-patch-1](https://github.com/nrwl/nx/tree/JamesHenry-patch-1) | | **Commit** | [856ef7f](856ef7f) | | **Workflow run** | [9497298216](https://github.com/nrwl/nx/actions/runs/9497298216) | --------- Co-authored-by: Katerina Skroumpelou <sk.katherine@gmail.com>
FrozenPandaz
pushed a commit
that referenced
this pull request
Jun 21, 2024
Redo of #26509, with more guards for unexpected missing/relative values within full releases in GitHub Actions. --- Refactors our publish workflow to support PR releases, in addition to our previous triggers. **Tests:** --- - Example of failure on non-PR release (comment skipped): https://github.com/nrwl/nx/actions/runs/9480869812 --- - Example of failure on PR release (comment created on PR): - https://github.com/nrwl/nx/actions/runs/9480852880 - #26515 (comment) --- - Example of dry-run of full release (`workflow_dispatch` with no PR number provided): https://github.com/nrwl/nx/actions/runs/9497871483 --- - Real PR release created here: | Release details | 📑 | | ------------- | ------------- | | **Published version** | [0.0.0-pr-26515-856ef7f](https://www.npmjs.com/package/nx/v/0.0.0-pr-26515-856ef7f) | | **Triggered by** | @JamesHenry | | **Branch** | [JamesHenry-patch-1](https://github.com/nrwl/nx/tree/JamesHenry-patch-1) | | **Commit** | [856ef7f](856ef7f) | | **Workflow run** | [9497298216](https://github.com/nrwl/nx/actions/runs/9497298216) | --------- Co-authored-by: Katerina Skroumpelou <sk.katherine@gmail.com> (cherry picked from commit 42749b8)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors our publish workflow to support PR releases, in addition to our previous triggers.
Tests:
workflow_dispatchwith no PR number provided): https://github.com/nrwl/nx/actions/runs/9497871483