feat(angular): add vitest option to angular #27311

yjaaidi · 2024-08-06T16:38:37Z

This adds vitest option to unitTestRunner for Angular generators.
This does not add vitest option to create-nx-workspace but I think we should provide this as an option in the future. Please let me know if you wantme to add this here or as a future feature.

vercel · 2024-08-06T16:38:41Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Updated (UTC)
nx-dev	⬜️ Ignored (Inspect)	Visit Preview	Oct 29, 2024 3:36pm

nx-cloud · 2024-08-06T16:39:39Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 80e346e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

🟥 Failed Commands
`nx affected --targets=lint,test,build,e2e,e2e-ci --base=f84b6e5c9736504fe27a7673ae99b0cd68afed7d --head=80e346e73d1067d2f29b4c408aa6a07ed4dc7254 --parallel=3`

✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

packages/angular/src/generators/utils/add-vitest.ts

packages/vite/src/generators/init/init.ts

packages/vite/src/utils/generator-utils.ts

Coly010

Looks great! I need to test it out properly, but other than the comments I've added, I don't see anything untoward.

Could you add some e2e tests that cover using Vitest as a selected option so that we can ensure behaviour continues to work going forward?

packages/angular/src/generators/utils/add-vitest.ts

packages/angular/src/utils/versions.ts

packages/vite/src/generators/configuration/schema.d.ts

yjaaidi · 2024-08-07T13:23:21Z

Looks great! I need to test it out properly, but other than the comments I've added, I don't see anything untoward.

Could you add some e2e tests that cover using Vitest as a selected option so that we can ensure behaviour continues to work going forward?

Of course! By the way, I also wanted to add an e2e to test the watch mode which is generally a common issue. As a matter of fact, the watch was detecting file changes and running the tests without rebuilding the TS. For some reason, I had to upgrade the angular plugin to 1.7.0 to make it work.
🤔 I wonder if it is worth exploring e2e tests for watch mode which can be pretty tricky.

jaysoo · 2024-09-12T13:07:23Z

packages/devkit/src/utils/find-file-in-closest-parent-folder.ts

+ * @param path The path relative to the workspace root to start searching from.
+ * @param fileName The name of the file to search for.
+ */
+export function findFileInClosestParentFolder(


It looks like this function is used for the purpose of detecting whether Node will treat a .js or .ts file as ESM or not (due to "type": "module" in package.json).

My suggestion is to explicitly use .mts (or .mjs, .cjs, .cts) file extensions so the format is controlled rather than let Node interpret it. In that case, we don't need this function in devkit.

Exactly! I thought that using .ts when possible would be less confusing to users and machines.
For instance, Playwright VSCode Plugin does not detect playwright.config.mts files. So there might be some plugins/tools that do not detect vite.config.mts.

Other than that, if you are fine with generating vite.config.mts all the time, we can get rid of this function and I'll be happy to fix this.

Let's generate vite.config.mts all the time and we can remove this function :)

the-ult · 2024-10-21T09:52:00Z

Is there any news on an ETA when this awesome new feature is gonna be available?

vercel · 2024-10-29T00:01:01Z

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

yjaaidi · 2024-10-29T10:15:33Z

Is there any news on an ETA when this awesome new feature is gonna be available?

Hey @the-ult , thanks for your interest to this PR.
I just made the changes requested by @jaysoo so hopefully it could ship soon.

the-ult · 2024-10-29T10:19:18Z

Is there any news on an ETA when this awesome new feature is gonna be available?

Hey @the-ult , thanks for your interest to this PR. I just made the changes requested by @jaysoo so hopefully it could ship soon.

Awesome.
Thanks for all the great work!

packages/angular/src/utils/versions.ts

brandonroberts

🫡

yjaaidi · 2024-10-29T16:14:45Z

@analogjs/vitest-angular is moving fast. There's a tradeoff there, but shouldn't we use a caret match instead of holding users back?

Coly010 · 2024-10-29T17:18:03Z

@analogjs/vitest-angular is moving fast. There's a tradeoff there, but shouldn't we use a caret match instead of holding users back?

I'd much rather pay the maintenance tax for updating minors more frequently given we support current Angular Major + 2 previous major versions with Nx. We can ensure better stability with all the versions we support this way.

wall-street-dev · 2024-10-29T19:09:25Z

Oh s*** back to Nx again.... cool stuff @yjaaidi 🔥🔥🔥

ErickRodrCodes · 2024-10-29T19:39:41Z

This is going to be so 🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥, Now we have to wait for serving/building to be under vite.

github-actions · 2024-11-05T00:11:46Z

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

yjaaidi requested review from a team as code owners August 6, 2024 16:38

yjaaidi requested review from Coly010 and jaysoo August 6, 2024 16:38

yjaaidi commented Aug 6, 2024

View reviewed changes

vercel bot deployed to Preview August 6, 2024 17:14 View deployment

yjaaidi requested a review from a team as a code owner August 6, 2024 23:32

vercel bot deployed to Preview August 7, 2024 00:43 View deployment

yjaaidi requested a review from a team as a code owner August 7, 2024 07:53

Coly010 reviewed Aug 7, 2024

View reviewed changes

FrozenPandaz assigned Coly010 Aug 9, 2024

yjaaidi requested review from FrozenPandaz, vsavkin and a team as code owners August 22, 2024 06:51

vercel bot deployed to Preview August 22, 2024 06:59 View deployment

vercel bot deployed to Preview August 22, 2024 07:46 View deployment

Coly010 changed the title ~~feat: add vitest option to angular~~ feat(angular): add vitest option to angular Aug 22, 2024

vercel bot deployed to Preview August 22, 2024 20:29 View deployment

yjaaidi requested a review from a team as a code owner August 23, 2024 08:07

vercel bot deployed to Preview August 23, 2024 08:22 View deployment

vercel bot deployed to Preview August 23, 2024 10:45 View deployment

vercel bot deployed to Preview August 23, 2024 22:29 View deployment

vercel bot deployed to Preview August 24, 2024 08:24 View deployment

Coly010 approved these changes Aug 26, 2024

View reviewed changes

vercel bot deployed to Preview September 5, 2024 08:34 View deployment

vercel bot deployed to Preview September 9, 2024 21:21 View deployment

yjaaidi added 2 commits September 10, 2024 09:33

test(angular,workspace): update snapshots

4711aba

chore(devkit): fix import

d5136c4

Coly010 force-pushed the feat/add-vitest-option-to-angular branch 2 times, most recently from d5136c4 to 03bdf3d Compare September 11, 2024 10:08

jaysoo reviewed Sep 12, 2024

View reviewed changes

Merge branch 'master' into feat/add-vitest-option-to-angular

8262f3c

yjaaidi force-pushed the feat/add-vitest-option-to-angular branch from 70db017 to 8262f3c Compare October 29, 2024 00:00

chore(angular): always generate vite/vitest config with mts extension

d56ce97

vercel bot deployed to Preview October 29, 2024 00:32 View deployment

chore(angular): update e2e test to use directory positional arg

3571d5a

Coly010 force-pushed the feat/add-vitest-option-to-angular branch from c3db560 to 3571d5a Compare October 29, 2024 11:03

brandonroberts reviewed Oct 29, 2024

View reviewed changes

packages/angular/src/utils/versions.ts Outdated Show resolved Hide resolved

feat(angular): bump analogViteVersion

46fd341

Coly010 requested review from jaysoo and brandonroberts October 29, 2024 13:12

jaysoo approved these changes Oct 29, 2024

View reviewed changes

brandonroberts approved these changes Oct 29, 2024

View reviewed changes

chore(devkit): remove wallaby config

80e346e

jaysoo merged commit 9fe8274 into nrwl:master Oct 29, 2024
4 of 6 checks passed

Tommy228 mentioned this pull request Oct 30, 2024

Support AnalogJS Vitest ngneat/spectator#679

Open

github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(angular): add vitest option to angular #27311

feat(angular): add vitest option to angular #27311

yjaaidi commented Aug 6, 2024 •

edited

Loading

vercel bot commented Aug 6, 2024 •

edited

Loading

nx-cloud bot commented Aug 6, 2024 •

edited

Loading

Coly010 left a comment

yjaaidi commented Aug 7, 2024

jaysoo Sep 12, 2024

yjaaidi Sep 12, 2024

Coly010 Sep 27, 2024

the-ult commented Oct 21, 2024 •

edited

Loading

vercel bot commented Oct 29, 2024

yjaaidi commented Oct 29, 2024

the-ult commented Oct 29, 2024

brandonroberts left a comment

yjaaidi commented Oct 29, 2024

Coly010 commented Oct 29, 2024

wall-street-dev commented Oct 29, 2024

ErickRodrCodes commented Oct 29, 2024

github-actions bot commented Nov 5, 2024

feat(angular): add vitest option to angular #27311

feat(angular): add vitest option to angular #27311

Conversation

yjaaidi commented Aug 6, 2024 • edited Loading

vercel bot commented Aug 6, 2024 • edited Loading

nx-cloud bot commented Aug 6, 2024 • edited Loading

☁️ Nx Cloud Report

Coly010 left a comment

Choose a reason for hiding this comment

yjaaidi commented Aug 7, 2024

jaysoo Sep 12, 2024

Choose a reason for hiding this comment

yjaaidi Sep 12, 2024

Choose a reason for hiding this comment

Coly010 Sep 27, 2024

Choose a reason for hiding this comment

the-ult commented Oct 21, 2024 • edited Loading

vercel bot commented Oct 29, 2024

yjaaidi commented Oct 29, 2024

the-ult commented Oct 29, 2024

brandonroberts left a comment

Choose a reason for hiding this comment

yjaaidi commented Oct 29, 2024

Coly010 commented Oct 29, 2024

wall-street-dev commented Oct 29, 2024

ErickRodrCodes commented Oct 29, 2024

github-actions bot commented Nov 5, 2024

yjaaidi commented Aug 6, 2024 •

edited

Loading

vercel bot commented Aug 6, 2024 •

edited

Loading

nx-cloud bot commented Aug 6, 2024 •

edited

Loading

the-ult commented Oct 21, 2024 •

edited

Loading