-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nx-plugin): plugins should not include spec files #5566
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/GwX9LmKtrbc1BQNL92dxJaYeEKLq [Deployment for 1344396 canceled] |
Glob pattern for assets previously picked up spec files. nrwl#5563
Note: This change adds an additional glob pass through plugin source code in workspace.json > projects > my-plugin > build > assets. This could be condensed to maintain 1 glob pass, but the result is much less readable. For future reference, the condensed glob section would look like:
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
*.spec.ts files are included when publishing a plugin
Expected Behavior
*.spec.ts files should not be included in built dist folder.
Related Issue(s)
Fixes #5563