Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nx-plugin): plugins should not include spec files #5566

Merged
merged 1 commit into from
May 7, 2021

Conversation

AgentEnder
Copy link
Member

Current Behavior

*.spec.ts files are included when publishing a plugin

Expected Behavior

*.spec.ts files should not be included in built dist folder.

Related Issue(s)

Fixes #5563

@vercel
Copy link

vercel bot commented May 5, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/GwX9LmKtrbc1BQNL92dxJaYeEKLq
✅ Preview: Canceled

[Deployment for 1344396 canceled]

@AgentEnder AgentEnder marked this pull request as draft May 5, 2021 15:30
@AgentEnder AgentEnder marked this pull request as ready for review May 5, 2021 18:34
Glob pattern for assets previously picked up spec files.
nrwl#5563
@AgentEnder
Copy link
Member Author

AgentEnder commented May 6, 2021

Note: This change adds an additional glob pass through plugin source code in workspace.json > projects > my-plugin > build > assets.

This could be condensed to maintain 1 glob pass, but the result is much less readable. For future reference, the condensed glob section would look like:

{
  input: './packages/core',
  glob: '**/@(!(*.ts)|@(*.d.ts))',
  output: './src'
}

@FrozenPandaz FrozenPandaz self-assigned this May 7, 2021
@FrozenPandaz FrozenPandaz merged commit c0d79ba into nrwl:master May 7, 2021
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin generator includes spec files in built output
2 participants