fix(web): default react builds to production when NODE_ENV is not set explicitly

[ndcunningham]

Current Behavior

Currently, react builds are not set to default to production (Look at the styles size)

Expected Behavior

Running yarn nx run project:build:production will now default NODE_ENV to production

Related Issue(s)

Fixes #7410

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/Bn5pZvecemrW2Eqt7VZoijSVY7nW
✅ Preview: Canceled

[nx-cloud]

Nx Cloud Report

CI ran the following commands for commit b1d6bf2. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status	Command
	nx affected --target=build --base=d39c1c17e9556d932c17823043c81b528280322c --head=b1d6bf25405eba118047d2480b3bb3c80a57c255 --parallel --max-parallel=3
	nx affected --target=e2e --base=d39c1c17e9556d932c17823043c81b528280322c --head=b1d6bf25405eba118047d2480b3bb3c80a57c255 --exclude=e2e-next,e2e-gatsby,e2e-workspace-create,e2e-workspace-integrations,e2e-workspace-core,e2e-react,e2e-web,e2e-angular-extensions,e2e-angular-core,e2e-cli,e2e-nx-plugin,e2e-storybook,e2e-cypress,e2e-node,e2e-linter,e2e-je...
	nx affected --target=e2e --base=d39c1c17e9556d932c17823043c81b528280322c --head=b1d6bf25405eba118047d2480b3bb3c80a57c255 --exclude=e2e-react-native,e2e-detox
	nx affected --target=lint --base=d39c1c17e9556d932c17823043c81b528280322c --head=b1d6bf25405eba118047d2480b3bb3c80a57c255 --parallel --max-parallel=4
	nx affected --target=test --base=d39c1c17e9556d932c17823043c81b528280322c --head=b1d6bf25405eba118047d2480b3bb3c80a57c255 --parallel --max-parallel=2
	nx build typedoc-theme

---

Sent with 💌 from NxCloud.

[puku0x]

@ndcunningham @jaysoo It seems process.env.NODE_ENV is conflicted by this PR.

[arthurgeek]

This is still producing big CSS files:

Here's the output of my build run:

$ yarn nx run client:build:production --skip-nx-cache
yarn run v1.22.17
$ /Users/arthurgeek/Development/app/node_modules/.bin/nx run client:build:production --skip-nx-cache

> nx run client:build:production 

warn - Tailwind is not purging unused styles because no template paths have been provided.
warn - If you have manually configured PurgeCSS outside of Tailwind or are deliberately not removing unused styles, set `purge: false` in your Tailwind config file to silence this warning.
warn - https://tailwindcss.com/docs/controlling-file-size/#removing-unused-css
Entrypoint main 136 KiB = runtime.bdc91b7b4b12a0bf.esm.js 1.04 KiB main.e6d8f0ef3ad6652b.css 1.87 KiB main.f95a1cfc8e159d59.esm.js 133 KiB
Entrypoint polyfills 87.3 KiB = runtime.bdc91b7b4b12a0bf.esm.js 1.04 KiB polyfills.7e0034cfe0406d00.esm.js 86.3 KiB
Entrypoint styles [big] 2.77 MiB = runtime.bdc91b7b4b12a0bf.esm.js 1.04 KiB styles.164b3a187a04d07d.css 2.77 MiB
chunk (runtime: runtime) main.e6d8f0ef3ad6652b.css, main.f95a1cfc8e159d59.esm.js (main) 150 KiB (javascript) 2.27 KiB (css/mini-extract) [initial] [rendered]
chunk (runtime: runtime) polyfills.7e0034cfe0406d00.esm.js (polyfills) 276 KiB [initial] [rendered]
chunk (runtime: runtime) styles.164b3a187a04d07d.css (styles) 50 bytes (javascript) 3.47 MiB (css/mini-extract) [initial] [rendered]
chunk (runtime: runtime) runtime.bdc91b7b4b12a0bf.esm.js (runtime) 3.02 KiB [entry] [rendered]
webpack compiled successfully (08148694879505e4)

———————————————————————————————————————————————

>  NX   SUCCESS  Running target "build" succeeded


✨  Done in 14.71s.

And here's my tailwind.config.js file:

const { createGlobPatternsForDependencies } = require('@nrwl/react/tailwind')

module.exports = {
  purge: createGlobPatternsForDependencies(__dirname),
  darkMode: false, // or 'media' or 'class'
  theme: {
    extend: {},
  },
  variants: {
    extend: {},
  },
  plugins: [],
}

[arthurgeek]

Like mentioned in #7410 the same config works in a Next.js app.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.