update rust-webservice template to use build container #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zer0x64
commented
Sep 19, 2025
Comment on lines
+69
to
+71
| if template == Template.RUST_WEBSERVICE: | ||
| with_build_container = True | ||
|
|
There was a problem hiding this comment.
I guess this could be simplified by assuming true if a build.yaml.j2 file is present in the template dir. However it can be a bit awkward to check with the current codebase
zer0x64
force-pushed
the
rust-webserver-build
branch
5 times, most recently
from
5637241 to
aa78075
Compare
zer0x64
force-pushed
the
rust-webserver-build
branch
from
aa78075 to
b6024e3
Compare
|
tu me diras quand c'est prêt à review |
|
Pret a review @Res260 :) |
MOBergeron
reviewed
Sep 26, 2025
MOBergeron
requested changes
Sep 26, 2025
MOBergeron
approved these changes
Sep 28, 2025
|
Apparently j'ais pas les rights pour merge 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does not currently work, check my related issue on the ctf repo.
Migrate the rust-webserver template to make use of build containers.