Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ON HOLD - init config for CALM sites layer #667

Closed
wants to merge 1 commit into from

Conversation

trey-stafford
Copy link
Contributor

@trey-stafford trey-stafford commented Jul 10, 2023

Description

Add Circumpolar Active Layer Monitoring (CALM) Network sites layer. It was recommended that we look at this data by Christina Schaedel.

This data is provided in a few different formats: a kml (Google Earth format) file that does not seem to contain useful attribute information, a 7-zipped shapefile that contains useful (but incomplete/misleading) attributes, and a microsoft xls document that appears to contain all of the data.

This PR adds data from the Shapefile. It has some issues:

  • It encodes missing data as 0, which could be a valid value
  • Attribute names are not correct. There is a column for each year from 1990-2022 in the excel spreadsheet but in the shapefile each of these columns is named "F8" - "F32" (F8 is 1990 and F32 is 2022).
  • There may be missing information about the type of measurement each record represents. The spreadsheet uses color as a label (e.g., red-highlighted records represent sites that use "spatially-oriented mechanical probing at regular intervals across a grid" while blue sites use "thaw-tube measurements".

Unfortunately the excel spreadsheet has headers/multiple sections and would probably require a Python script to completely parse out. Given that there are no sites in Greenland, maybe we should hold off on this layer and consider others first.

Checklist

If an item on this list is done or not needed, simply check it with [x].

  • Config lockfile updated (inv config.export > qgreenland/config/cfg-lock.json)
  • Version bumped if needed (bumpversion (major|minor|patch|prerelease|build)
  • CHANGELOG.md updated
  • Documentation updated if needed
  • New unit tests if needed

TODOs related to dataset citation and dataset description
@trey-stafford
Copy link
Contributor Author

CALM_screenshot

@trey-stafford trey-stafford linked an issue Jul 10, 2023 that may be closed by this pull request
@MattF-NSIDC
Copy link

MattF-NSIDC commented Jul 10, 2023

Unfortunately the excel spreadsheet has headers/multiple sections and would probably require a Python script to completely parse out. Given that there are no sites in Greenland, maybe we should hold off on this layer and consider others first.

I'm thinking hold off as well. We'd be adding specialist logic for something that may not have much value for our users, given there are no features in Greenland.

The space cost of this layer is really low though, so maybe we shouldn't rule it out long-term. Maybe eventually this data will be available, accurately, in an open, standards-based geospatial format anyway!

We could keep this PR open, maybe give it a label or milestone so we know at a glance why it'll be idling around long-term?

@trey-stafford
Copy link
Contributor Author

Actually, there are three sites in Greenland - my initial glancing at the data w/ the default symbology wasn't good enough 😅

@MattF-NSIDC
Copy link

Ah. Do you feel this layer will be particularly valuable? The ratio of cost:benefit I feel may still not be worth making this layer a priority because of the format issues.

@MattF-NSIDC MattF-NSIDC changed the title WIP - init config for CALM sites layer ON HOLD - init config for CALM sites layer Jul 12, 2023
@MattF-NSIDC
Copy link

We discussed and:

  • We have no idea which piece of this dataset is the source of truth. The excel spreadsheet, KML, and shapefile all have weird mismatches, e.g. shapefile has 0 where spreadsheet has NULL. What is the source of truth?

  • We feel that this layer could wait until later. We've got a long list of other layers to consider and if we have left-over time at the end of our scheduled grant work, we can always come back to this. Perhaps by the data quality will have improved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frozen ground layer updates/additions
2 participants