-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store initial voter reward data in the NEO balance #2844
Comments
NeoFS mainnet sidechain can also be tried (it's much longer than T5, so more interesting wrt this problem) after #2848. |
I'm working on https://github.com/ZhangTao1596/neo/tree/fix-vote-reward. Once it works, I will port to neo-go. |
It's OK, I just think that NeoGo is a bit easier to work with, there are more tests there and you can quickly synchronize the chain from dump. But the protocol is the same, we can start with C# implementation, some effects should be visible there as well. |
I have compared gas balances of neo-project/neo#2841 on Testnet. Now I'm testing neo-go https://github.com/ZhangTao1596/neo-go/tree/optimize-vote-reward |
Signed-off-by: ZhangTao1596 <zhangtao@ngd.neo.org>
Signed-off-by: ZhangTao1596 <zhangtao@ngd.neo.org>
It can be non-zero even if VoteTo is NULL. Fixes state diff with 3.6.0: block 41660: value mismatch for key +////xTrvgat3qG/w8hQoD/I4MgUz6rygA==: QQQhAS8hA7yiAAAhAA== vs QQQhAS8hA7yiAAAhB+POSWfBCAE= Related to #2844. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Implement and test the second option from neo-project/neo#2815 (comment). Unit tests can be omitted for the first iteration, but we need to:
db restore
for testnet and mainnet with storage dumps saved on a regular node and on a patched one, thenscripts/compare-dumps
can be adjusted to only compare GAS balances; obviously we need to have exactly the same balances in the patched version as we have on a regular nodedb restore
for testnet, mainnet and NeoFS T5 testnet sidechain (without storage dumps) on the same machine with LevelDB/BoltDB andKeepOnlyLatestState
enabled/disabled, check for restoration time and the resulting DB sizeThe expectation is that we would have noticeably smaller DB and better time for NeoFS sidechain, probably better time and about the same size for testnet/mainnet. If that expectation is met, we can propose this change to neo-project/neo and then either complete it as an option (I really expect it to be useful for NeoFS chains) or a proper protocol change (3.7.0/3.8.0).
The text was updated successfully, but these errors were encountered: