Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

state: always deserialize LastGasPerVote #3122

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

roman-khimov
Copy link
Member

It can be non-zero even if VoteTo is NULL. Fixes state diff with 3.6.0:

block 41660: value mismatch for key +////xTrvgat3qG/w8hQoD/I4MgUz6rygA==: QQQhAS8hA7yiAAAhAA== vs QQQhAS8hA7yiAAAhB+POSWfBCAE=

Related to #2844.

It can be non-zero even if VoteTo is NULL. Fixes state diff with 3.6.0:

  block 41660: value mismatch for key +////xTrvgat3qG/w8hQoD/I4MgUz6rygA==: QQQhAS8hA7yiAAAhAA== vs QQQhAS8hA7yiAAAhB+POSWfBCAE=

Related to #2844.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #3122 (9bdf66a) into master (c6850b4) will decrease coverage by 0.04%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##           master    #3122      +/-   ##
==========================================
- Coverage   84.86%   84.82%   -0.04%     
==========================================
  Files         330      330              
  Lines       44323    44322       -1     
==========================================
- Hits        37614    37597      -17     
- Misses       5201     5212      +11     
- Partials     1508     1513       +5     
Files Changed Coverage Δ
pkg/core/state/native_state.go 70.43% <40.00%> (-0.26%) ⬇️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@roman-khimov roman-khimov merged commit a703e54 into master Sep 6, 2023
12 of 18 checks passed
@roman-khimov roman-khimov deleted the fix-neo-state-deserialization branch September 6, 2023 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants