Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for compiler/emit #534

Closed
volekerb opened this issue Dec 2, 2019 · 3 comments
Closed

Add unit tests for compiler/emit #534

volekerb opened this issue Dec 2, 2019 · 3 comments
Assignees
@fyrchik
Labels
good first issue Good for newcomers help wanted Extra attention is needed test Unit tests
Milestone
v0.72.2

Comments

@volekerb
Copy link
Contributor

volekerb commented Dec 2, 2019

We have weak coverage and it's good to have them to check yourself while doing refactoring.
@volekerb volekerb added the test Unit tests label Dec 2, 2019
@volekerb volekerb mentioned this issue Dec 2, 2019
Merged
@roman-khimov
Copy link
Member

Maybe we're better solving #449 first and then see what's left for this one.

@roman-khimov roman-khimov added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 2, 2019
@volekerb
Copy link
Contributor Author

volekerb commented Dec 2, 2019

hm. I would prefer to have unit tests before refactoring

@roman-khimov
Copy link
Member

I mean I want to avoid merging two implementations and then throwing one test set away. We have at least some coverage for vm that could be reused.

@fyrchik fyrchik mentioned this issue Feb 5, 2020
Merged
@roman-khimov roman-khimov added this to the v0.73.0 milestone Feb 8, 2020
roman-khimov added a commit that referenced this issue Feb 8, 2020
@roman-khimov
Merge pull request #642 from nspcc-dev/feature/emit
9b9adb2 
vm, compiler: move Emit* functions to a separate package

Closes #449, #534.
@roman-khimov roman-khimov modified the milestones: v0.73.0, v0.72.2 Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fyrchik fyrchik

Labels
good first issue Good for newcomers help wanted Extra attention is needed test Unit tests
Projects
None yet
Milestone
v0.72.2
Development

No branches or pull requests
3 participants
@volekerb @fyrchik @roman-khimov