Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm, compiler: move Emit* functions to a separate package #642

Merged
merged 9 commits into from
Feb 8, 2020

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Feb 3, 2020

Closes #449, #534 .

@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #642 into master will increase coverage by 0.57%.
The diff coverage is 85.83%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #642      +/-   ##
=========================================
+ Coverage   64.32%   64.9%   +0.57%     
=========================================
  Files         126     125       -1     
  Lines       10597   10497     -100     
=========================================
- Hits         6817    6813       -4     
+ Misses       3477    3406      -71     
+ Partials      303     278      -25
Impacted Files Coverage Δ
pkg/vm/emit/bigint.go 95.77% <ø> (ø)
pkg/core/blockchain.go 31.24% <100%> (+0.06%) ⬆️
pkg/vm/stack.go 91.45% <100%> (ø) ⬆️
pkg/smartcontract/contract.go 60% <100%> (+33.68%) ⬆️
pkg/vm/stack_item.go 75.64% <100%> (ø) ⬆️
pkg/vm/serialization.go 95.29% <100%> (ø) ⬆️
pkg/rpc/txBuilder.go 50% <64.51%> (+11.05%) ⬆️
pkg/vm/emit/emit.go 83.75% <83.75%> (ø)
pkg/compiler/codegen.go 86.78% <91.89%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab14a46...a8dc704. Read the comment docs.

@roman-khimov roman-khimov merged commit 9b9adb2 into master Feb 8, 2020
@roman-khimov roman-khimov deleted the feature/emit branch February 8, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler Go smart contract compiler vm VM tasks/bugs/issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract same pieces of vm/emit.go and compiler/emit.go
2 participants