Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcsrv: allow one-block slippage in TestWSClient_SubscriptionsCompat #3397

Merged
merged 1 commit into from
Apr 4, 2024

Commits on Apr 4, 2024

  1. rpcsrv: allow one-block slippage in TestWSClient_SubscriptionsCompat

    Close #2956. The failure reason is similar to the one described in #3396
    for TestNotary: Blockchain's notificationDispatcher is listening to
    block events from storeBlock via separate channel. By the moment single
    block addition is finished, notification may or may not be properly
    handled by notificationDispatcher, especially given the fact that our
    runners are slow. As a result, assert.Eventually with 1-second awaiting
    period may fail. This issue is solved by adding one more block, because
    the second AddBlock finishes only when it sends block addition event to
    notificationDispatcher loop, which means that the previous event was
    handled.
    
    Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
    AnnaShaleva committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    ef3ec19 View commit details
    Browse the repository at this point in the history