Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm: use truncated division for Integers #773

Merged
merged 1 commit into from
Mar 23, 2020
Merged

vm: use truncated division for Integers #773

merged 1 commit into from
Mar 23, 2020

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Mar 17, 2020

When divisor is negative, the result is truncated towards
zero.

https://dotnetfiddle.net/qWwtyN

Closes #768 .

When divisor is negative, the result is truncated towards
zero.
@codecov
Copy link

codecov bot commented Mar 17, 2020

Codecov Report

Merging #773 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #773   +/-   ##
=======================================
  Coverage   64.31%   64.31%           
=======================================
  Files         141      141           
  Lines       12923    12923           
=======================================
  Hits         8311     8311           
  Misses       4209     4209           
  Partials      403      403
Impacted Files Coverage Δ
pkg/vm/vm.go 78.01% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a87f849...4b44190. Read the comment docs.

@roman-khimov
Copy link
Member

Have you tested it for #768? Not that it's bad, but just to make sure.

@roman-khimov
Copy link
Member

I guess it takes about 17-20 hours to reach this block now starting from zero. But to make a real test you have to start from zero, as there might be regressions.

@roman-khimov roman-khimov merged commit 5148b98 into master Mar 23, 2020
@roman-khimov roman-khimov deleted the fix/bigint branch March 23, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working vm VM tasks/bugs/issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Difference in state changes at mainnet's block 2613427
2 participants