Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm: use truncated division in MOD #826

Merged
merged 1 commit into from
Apr 6, 2020
Merged

vm: use truncated division in MOD #826

merged 1 commit into from
Apr 6, 2020

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Apr 6, 2020

Mimic C#'s % behavior. https://dotnetfiddle.net/BaVazY
Related 4b44190 (#773).

Mimic C#'s `%` behavior.
Related 4b44190 (#773).
@codecov
Copy link

codecov bot commented Apr 6, 2020

Codecov Report

Merging #826 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #826   +/-   ##
=======================================
  Coverage   67.65%   67.65%           
=======================================
  Files         141      141           
  Lines       13163    13163           
=======================================
  Hits         8906     8906           
  Misses       3849     3849           
  Partials      408      408           
Impacted Files Coverage Δ
pkg/vm/vm.go 77.99% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0b5271...0023c4f. Read the comment docs.

@roman-khimov roman-khimov added this to the v0.75.0 milestone Apr 6, 2020
@roman-khimov roman-khimov merged commit 48e619e into master Apr 6, 2020
@roman-khimov roman-khimov deleted the fix/mod branch April 6, 2020 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working vm VM tasks/bugs/issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants