Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: set config.Version properly #816

Merged
merged 2 commits into from
Apr 1, 2020
Merged

Makefile: set config.Version properly #816

merged 2 commits into from
Apr 1, 2020

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Apr 1, 2020

After moving Version variable to another package, Makefile should also be changed.

@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #816 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #816   +/-   ##
=======================================
  Coverage   67.65%   67.65%           
=======================================
  Files         141      141           
  Lines       13204    13204           
=======================================
  Hits         8933     8933           
  Misses       3859     3859           
  Partials      412      412           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b5dab5...98012fd. Read the comment docs.

Makefile Outdated Show resolved Hide resolved
After refactoring in 5a984fd (#423) Version has moved
to pkg/. Makefile should be changed accordingly.
@roman-khimov
Copy link
Member

Caused by #810.

Accept strings with spaces.
@roman-khimov roman-khimov merged commit 1e0a320 into master Apr 1, 2020
@roman-khimov roman-khimov deleted the fix/config branch April 1, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants