Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return STHTTPRequest #49

Closed
wants to merge 2 commits into from
Closed

return STHTTPRequest #49

wants to merge 2 commits into from

Conversation

MP0w
Copy link

@MP0w MP0w commented Nov 18, 2013

return STHTTPRequest for statusUpdateWithMedia so you can use the progressBlock

return STHTTPRequest
Usefull (?) methods for NSString+STTwitter Category
@nst
Copy link
Owner

nst commented Nov 18, 2013

Thank you for submitting your code.

You're totally right to be willing to track media upload progress.

I went another way, though, by adding an uploadProgressBlock the the most generic -fetchResource:.. method of STTwitterProtocol.

I'm sure it will suit your needs 0e15245

@nst
Copy link
Owner

nst commented Nov 18, 2013

Regarding the additional methods on NSString I'm not sure they should be integrated to the project.

First, they are not really needed to write a Twitter client.

Also, I think we could find several edge cases where the methods do not return the expected result.

So, if you don't mind, I would prefer not to integrate them at the moment.

Thank you again for proposing code and ideas. This is really how we can build a great library.

@nst nst closed this Nov 18, 2013
@MP0w
Copy link
Author

MP0w commented Nov 18, 2013

The additional methods as been pushed as mistake, are just test I did on my client.
Your Library is really great, I stopped the development of my client because I was hating twitter APIs for some reasons, this Library make me want to continue, seriously thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants