Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate new logo #431

Merged
merged 1 commit into from
May 9, 2019
Merged

Conversation

elnappo
Copy link
Member

@elnappo elnappo commented Apr 30, 2019

image
image

@elnappo elnappo added this to the 0.13 release milestone Apr 30, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling 8ab3eb4 on elnappo:integrate_logo into 300e650 on nsupdate-info:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling 8ab3eb4 on elnappo:integrate_logo into 300e650 on nsupdate-info:master.

@coveralls
Copy link

coveralls commented Apr 30, 2019

Coverage Status

Coverage remained the same at 66.474% when pulling 0a3bf17 on elnappo:integrate_logo into 300e650 on nsupdate-info:master.

Copy link
Member

@ThomasWaldmann ThomasWaldmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (besides the typos).

merge after fixing the typos?

{% block title %}{% trans "Log in" %}{% endblock %}

{% block content %}
<div class="row">
<div class="col-md-6">
<h2>{% trans "Login with a local Account" %}</h2>
<h2><img src="{% static "img/logo.svg" %}" alt="nsudpate.info logo" height="35" width="35"> {% trans "Login with a local Account" %}</h2>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo nsudpate

@@ -18,7 +18,7 @@ <h4>rDNS: <span id="ipv6_rdns" class="ipv6addr">{{ request.session.ipv6_rdns }}<
{% include "main/includes/home_middle.html" %}
<div class="row">
<div class="col-sm-12" style="text-align: center">
<h1>{{ WWW_HOST }} &mdash; {% trans "the Dynamic DNS service you waited for." %}</h1>
<h1><img src="{% static "img/logo_black.svg" %}" alt="nsudpate.info logo" height="35" width="35"> {{ WWW_HOST }} &mdash; {% trans "the Dynamic DNS service you waited for." %}</h1>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@@ -94,7 +95,7 @@
</ul>
</li>
</ul>
</div>_blac
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops?

@elnappo elnappo force-pushed the integrate_logo branch 2 times, most recently from 746f91c to efe8ace Compare May 2, 2019 19:02
@elnappo
Copy link
Member Author

elnappo commented May 2, 2019

Also added the logo to README.rst.

README.rst Outdated
@@ -1,5 +1,4 @@
About nsupdate.info
===================
.. image:: logo/logotype_blue.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please no README.rst changes - we use this from setup.py and i suspect this won't work for pypi.org.

@elnappo
Copy link
Member Author

elnappo commented May 3, 2019

removed logo from readme

@ThomasWaldmann ThomasWaldmann merged commit 78616cd into nsupdate-info:master May 9, 2019
@ThomasWaldmann
Copy link
Member

thanks!

@ThomasWaldmann ThomasWaldmann mentioned this pull request May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants