Use different data source for Pandas to GEOJson example #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on Review Jupyter notebook visual diffs & provide feedback on notebooks. Powered by ReviewNB |
MSeal
approved these changes
Jul 17, 2020
| "nbformat_minor": 0 | ||
| } | ||
| "nbformat": 4, | ||
| "nbformat_minor": 0 |
There was a problem hiding this comment.
@captainsafia Are we not saving notebook files as 4.4 version when persisting? The format is clearly 4.4 despite the 4.0 indicator here. Should I create a separate issue for that?
There was a problem hiding this comment.
@MSeal Yes -- we preserve the minor format version from the original document which is why we get into this weird scenario.
I think this is a bug in commutable and not intentional behavior.
|
Merging this. I created a separate issue to resolve the underlying issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original datasource is no longer available. Switch to the correct data source (311 calls), and modify the dataframe to use the correct column names. NOTE: For me, I get no syntax errors when I run the notebook in nteract desktop, however, I don't get any columns to show up. Just a blank map. I'm not familiar with how it's supposed to work.