Hydrogen keybindings

[n-riesco]

Moving the discussion from here and here.

---

Shall we add a setting to enable the keybindings that we would like to introduce in Hydrogen v1.0.0?

? hydrogen:inspect

C-enter hydrogen:run
S-enter hydrogen:run-and-move-down

A-C-enter hydrogen:run-cell
A-S-enter hydrogen:run-cell-and-move-down

? hydrogen:add-break-point
S-backspace hydrogen:remove-latest-break-point
S-A-backspace hydrogen:remove-all-break-points

? hydrogen:clear-results

A-S-C-enter hydrogen:run-all

---

Currently, we're shadowing

S-C-enter hydrogen:run-and-move-down editor:newline-above
C-backspace hydrogen:clear-results editor:delete-to-beginning-of-word

[lgeiger]

hydrogen:clear-results on the mac is mapped to cmd-alt-backspace, is ctrl-alt-backspace available on linux and windows?

For me I have hydrogen:inspect mapped to cmd-ctr-i to avoid complications with atom-script (which uses cmd-i and shift-cmd-i) but that wouldn't work on windows. What do you think about alt-i?

For hydrogen:add-break-point on mac, cmd-ctrl-b would work, but I couldn't come up with a great shortcut for windows. A second option would be C-S-m and rename "break-point" to something with "marker" in it.

@n-riesco Shall we add a setting to enable the keybindings that we would like to introduce in Hydrogen v1.0.0?

I like this idea, but is there an easy way of changing between two sets of keybindings in atom?

[n-riesco]

On 21/06/16 23:11, Lukas Geiger wrote:

|hydrogen:clear-results| on the mac is mapped to cmd-alt-backspace, is ctrl-alt-backspace available on linux and windows?

It's assigned to bracket-matcher:remove-matching-brackets.

For me I have |hydrogen:inspect| mapped to cmd-ctr-i to avoid complications with |atom-script| (which uses cmd-i and shift-cmd-i) but that wouldn't work on windows. What do you think about alt-i?

alt-i is free in linux

For |hydrogen:add-break-point| on mac, cmd-ctrl-b would work, but I couldn't come up with a great shortcut for windows. A second option would be C-S-m and rename "break-point" to something with "marker" in it.

shit-ctrl-b would work in linux

@n-riesco <https://github.com/n-riesco> Shall we add a setting to enable the keybindings that we would like to introduce in Hydrogen v1.0.0?

I like this idea, but is there an easy way of changing between two sets of keybindings in atom?

I don't know if there is an API to do this dynamically, but if there isn't, we can hack our way like this:

• define hydrogen-exp:* commands that are equivalent to the corresponding hydrogen:*. This experimental commands would run only if the experimental setting is enabled. If it isn't enabled, they would call evt.abortKeyBinding().
• register the exp and no-exp keybindings in keymap/hydrogen.cson

[n-riesco]

https://atom.io/docs/api/v1.8.0/KeymapManager

[lgeiger]

We can rename the keymaps folder (so no keymaps are loaded by default) and use atom.keymaps.loadKeymap to load the desired keymaps file.
But in order to make this work, we have to remove the activationCommands from package.json because there would be no way of activating Hydrogen with a keymap. Instead Hydrogen would be activated on startup of atom.

[n-riesco]

What would be the drawbacks of activating Hydrogen on startup?

I guess we could do something like this:

• on startup invoke:
  • Config.onDidChange with a callback to handle changes in the Hydrogen setting to toggle the experimental features;
  • and atom.workspace.observeActivePaneItem with another callback to:
    • dispose previous subscriptions (commands, observers, keymaps)
    • if there isn't a running kernel for this pane, only register commands and the keymap to start a kernel
    • if there is a running kernel, then register all the commands and the full keymap

---

Relevant links:

• https://atom.io/docs/api/v1.8.0/Config#instance-onDidChange
• https://atom.io/docs/api/v1.8.0/Workspace#instance-observeActivePaneItem
• https://atom.io/docs/api/v1.8.0/KeymapManager#instance-loadKeymap
• https://github.com/atom/atom/blob/v1.8.0/src/package.coffee#L220

[n-riesco]

@lgeiger The main problem I see with the KernelManager.loadKeymap is that it doesn't return the the corresponding CompositeDisposible, that would allow us to unload the keymap when the experimental setting changes.

At the moment I think that the hacky way I proposed above is easier.

[lgeiger]

You're right. With kernelManager.loadKeymap changing the keymap would require a restart of Atom.