[SSDP] Extract HTTP user-agent when available. #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dsokoloski , do you have a pcap triggering this feature? If so, could you add it, please? |
dsokoloski
force-pushed
the
pr-ssdp-user-agent
branch
from
7d58b9c
to
5841c83
Compare
You need to attach |
[SSDP] Added capture file with UA header. [SSDP] Added pcap test output log file. Signed-off-by: Darryl Sokoloski <darryl@sokoloski.ca>
dsokoloski
force-pushed
the
pr-ssdp-user-agent
branch
from
5841c83
to
cc2cf5f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
IvanNardi
reviewed
Mar 26, 2022
|
I tried to update this PR but I faced some permission issues. So I am going to merge it "as-is" and add the other stuff in a separated commit |
IvanNardi
approved these changes
Mar 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For device discovery/detection, the SSDP user-agent (when available) is usually very accurate.
Signed-off-by: Darryl Sokoloski darryl@sokoloski.ca