Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved AES-NI check. #1536

Merged
merged 1 commit into from
Apr 30, 2022
Merged

Improved AES-NI check. #1536

merged 1 commit into from
Apr 30, 2022

Conversation

utoni
Copy link
Collaborator

@utoni utoni commented Apr 30, 2022

  • A library should not open a subshell

Signed-off-by: lns matzeton@googlemail.com

 * A library should not open a subshell

Signed-off-by: lns <matzeton@googlemail.com>
@sonarcloud
Copy link

sonarcloud bot commented Apr 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@IvanNardi IvanNardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e4318ff introduced a huge performance drop (on ubuntu 20.04, x86_64, at least).
This patch seems to restore the old performance.
Therefore, even if I am not able to test it on different environments, I am going to merge it

@IvanNardi IvanNardi merged commit 02d0b5f into ntop:dev Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants