Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Xiaomi HTTP detection. #1546

Merged
merged 1 commit into from
May 10, 2022
Merged

Improved Xiaomi HTTP detection. #1546

merged 1 commit into from
May 10, 2022

Conversation

utoni
Copy link
Collaborator

@utoni utoni commented May 10, 2022

  • Merged Xiaomi pcap files

Signed-off-by: lns matzeton@googlemail.com

 * Merged Xiaomi pcap files

Signed-off-by: lns <matzeton@googlemail.com>
@sonarcloud
Copy link

sonarcloud bot commented May 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@IvanNardi
Copy link
Collaborator

How did you merge the two pcaps (with different snapshot lengths), creating a new one that ndpiReader is able to open? Plain mergecap didn't work for me in the past...

@utoni
Copy link
Collaborator Author

utoni commented May 10, 2022

I've used mergecap to merge those pcaps, but indeed ndpiReader did not like the result.
So I tried to open it with wireshark and exported it again as pcap.
It seems that when merging different pcap (formats? versions?) it can result in pcaps that can not be used for ndpiReader.
Not sure if the issue is related to mergecap or ndpiReader (or more precisely libpcap).

@IvanNardi
Copy link
Collaborator

So I tried to open it with wireshark and exported it again as pcap.

Thanks for that advice!!

@IvanNardi IvanNardi merged commit 7049204 into ntop:dev May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants