Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added HAProxy protocol. #2088

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Added HAProxy protocol. #2088

merged 1 commit into from
Oct 2, 2023

Conversation

utoni
Copy link
Collaborator

@utoni utoni commented Sep 29, 2023

Fixed wrong tests/do.sh.in "failed pcaps" logging.

IMHO most of the HAProxy payload is HTTP / TLS so it would make sense to use the subprotocol semantics here. However, the TLS dissector is not ready to get called as subprotocol dissector unfortunately.

Copy link
Collaborator

@IvanNardi IvanNardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an entry to doc/protocols.rst, please?

 * fixed tests/do.sh.in failure print

Signed-off-by: lns <matzeton@googlemail.com>
Signed-off-by: Toni Uhlig <matzeton@googlemail.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@utoni utoni merged commit a98d7ff into ntop:dev Oct 2, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants