add ethereum protocol dissector. #2111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utoni
reviewed
Oct 24, 2023
|
Please rebase to the It is also mandatory to add a new entry to |
mmaatuq
force-pushed
the
add_ethereum_protocol
branch
from
7821a1c
to
6bb654e
Compare
as explained here for bitcoin https://www.ntop.org/guides/nDPI/protocols.html#ndpi-protocol-bitcoin the same is applicable for ethereum. ethereum detection was removed from mining protocol and is now handled separately. Signed-off-by: Mahmoud Maatuq <mahmoudmatook.mm@gmail.com>
mmaatuq
force-pushed
the
add_ethereum_protocol
branch
from
6bb654e
to
32448d1
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Same. |
utoni
approved these changes
Oct 25, 2023
|
@mmaatuq , thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as explained here for bitcoin https://www.ntop.org/guides/nDPI/protocols.html#ndpi-protocol-bitcoin the same is applicable for ethereum.
ethereum detection was removed from mining protocol and is now handled separately.
Please sign (check) the below before submitting the Pull Request:
Describe changes: