Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP on-prem agent Azure pipeline pool logic #1021

Closed
wants to merge 1 commit into from

Conversation

MarkZither
Copy link

This PR addresses #1019, I added a new AzurePipelineImage of OnPrem and a string array property OnPremPools.

The code in AzurePipelinesAttribute is a bit of copy and paste of GetStage, GetJob and GetSteps to allow the pool name to be passed as a string rather than passing the AzurePipelineImage and the nested ternary in AzurePipelinesCacheStep AdjustedPath needs improving, but it is currently working as I hoped.

Input like

[AzurePipelines(
    suffix: null,
    AzurePipelinesImage.OnPrem,
    OnPremPools = new[] { "my-onprem-pool" },

give me the output I want

stages:
  - stage: my_onprem_pool
    displayName: 'my-onprem-pool'
    dependsOn: [  ]
    pool: 'my-onprem-pool'

I confirm that the pull-request:

  • [ x ] Follows the contribution guidelines
  • [ x ] Is based on my own work
  • [ x ] Is in compliance with my employer

@matkoch
Copy link
Member

matkoch commented Nov 15, 2022

I don't think that's a great implementation. OnPrem is not an image, so why put it in AzurePipelinesImage ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants