Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dotnet run command #1405

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

jwfx
Copy link
Contributor

@jwfx jwfx commented Aug 3, 2024

Fixes #1403

Main goal was to get AddProperty() working, as dotnet run requires --property parameters instead of /property.

Added all missing parameters to dotnet run, while taking parameters from dotnet run --help of .NET SDK 8.0.303 as source of truth.

There is some inconsistency between dotnet run docs and dotnet run --help. The docs have parameters (e.g. --force) that --help is not showing and it in turn shows parameters like --self-contained which are not part of the docs.

Let me know if I made the wrong call here.

I confirm that the pull-request:

  • Follows the contribution guidelines
  • Is based on my own work
  • Is in compliance with my employer

@matkoch
Copy link
Member

matkoch commented Aug 3, 2024

That's a whole bunch of duplication. Why not change /property here?

"format": "/property:{value}",

@jwfx jwfx force-pushed the update-dotnet-run-command branch from 06e8e17 to f5c51fe Compare August 4, 2024 17:44
@jwfx
Copy link
Contributor Author

jwfx commented Aug 4, 2024

Initially I wasn't sure all relevant dotnet commands would actually support the --property syntax, because of the spotty documentation on MS side.

I took the time to verify it for
build
clean
pack
publish
restore
run
test

So I made the change for commonTaskProperties as per your suggestion.

It looks like we still need the duplication though, because dotnet msbuild does not support this syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dotnet run does not support /property MSBuild parameters
2 participants