Skip to content

git clone does not work with "depth" option (#32) #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2018
Merged

git clone does not work with "depth" option (#32) #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fc0458
close stdin after completing the copy body to stdin (#32)
vvatanabe May 14, 2018
05a72e0
add test for git clone with depth option (#32)
vvatanabe May 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Intellij idea
.idea/*
*.iml

# Binaries for programs and plugins
*.exe
Expand Down
3 changes: 3 additions & 0 deletions githttpxfer/githttpxfer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,9 @@ func (ghx *GitHTTPXfer) serviceRPC(ctx Context, rpc string) {
RenderInternalServerError(res.Writer)
return
}
// "git-upload-pack" waits for the remaining input and it hangs,
// so must close it after completing the copy request body to standard input.
stdin.Close()

res.SetContentType(fmt.Sprintf("application/x-git-%s-result", rpc))
res.WriteHeader(http.StatusOK)
Expand Down
7 changes: 7 additions & 0 deletions githttpxfer/githttpxfer_end_to_end_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,10 @@ func Test_End_To_End_it_should_succeed_clone_and_push_and_fetch_and_log(t *testi

destDirNameA := "test_a"
destDirNameB := "test_b"
destDirNameC := "test_c"
destDirPathA := path.Join(endToEndTestParams.workingDirPath, destDirNameA)
destDirPathB := path.Join(endToEndTestParams.workingDirPath, destDirNameB)
destDirPathC := path.Join(endToEndTestParams.workingDirPath, destDirNameC)

if _, err := execCmd("", "git", "clone", remoteRepoUrl, destDirPathA); err != nil {
t.Errorf("execute command error: %s", err.Error())
Expand Down Expand Up @@ -148,6 +150,11 @@ func Test_End_To_End_it_should_succeed_clone_and_push_and_fetch_and_log(t *testi
return
}

if _, err := execCmd("", "git", "clone", "--depth=1", remoteRepoUrl, destDirPathC); err != nil {
t.Errorf("execute command error: %s", err.Error())
return
}

}

func Test_End_To_End_it_should_succeed_request_to_get_info_refs(t *testing.T) {
Expand Down