-
Notifications
You must be signed in to change notification settings - Fork 75
Final Project Enrique #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Dear Instructors, I am submiting my final project. Any feedback will be really appreciated, I am giving in this notebook a quite extensive introduction to scanning probe microscopy simulations and two bonus schemes are provided: Verlet and Runge Kutta 4. |
Very interesting and well laid out notebook. Substantial piece of work! It was an excellent idea to start with the simple harmonic motion to test your code, before adding tip forces. This is the way to develop numerical codes! I'm also very pleased to see the error analysis, and of course the new integrators. Why do you have section headings preceded by "3"? (3.1, 3.2, 3.3, etc.) You forgot to say what Q is, when you first use it (Equation 1). At the end of this section of text (and before the code starts), you mention "quality factor," but your reader likely does not know what this is. In fact, all symbols should be defined, even if most of them are familiar to many readers. Yay for loading NumPy like you did! :-)
Error analysis: RK4 gives smaller errors, as you mention, by one order of magnitude. Here's an interesting question: how does the time-to-solution compare for the same error? (RK4 presumably takes longer to compute for a given dt). I would be happy to merge this pull request to add your notebook to the NumericalMOOC "knowledge base," but there are so many typos! If you have time, it would be great if you could fix these. Typos & style –use a backslash before functions in LaTeX mode to get roman type: \cos, \arctan as most self-contained as possible—>just say "self-contained" (Verlet) ... around (RK4) ... However, we have—> delete "However" – There are many, many missing commas! |
Dear Professor Barba and instructors, I have made the changes suggested, and I think it is ready to be merged. I have checked the text in a text editor in order to check spelling error and typos, besides correcting all the typos that you kindly pointed out. Thank you! Enrique |
Final Project Enrique. We can't merge without the last commit, but the diff is minimal.
No description provided.