Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows user to choose the default colour #50

Merged
merged 1 commit into from
Apr 26, 2015

Conversation

cisoun
Copy link
Contributor

@cisoun cisoun commented Apr 26, 2015

Let the user choose the folders default color.
The script asks the user for the color after the style and replaces the symbolic links.

@Foggalong
Copy link
Contributor

Woah, I wasn't expecting this! The code is a lot shorter than what I was implementing too - I'll check the repo out asap :)

@@ -99,7 +99,29 @@ else
gerror
fi

cp -rH files/"${style}"/Numix/* "${dir}"/Numix/
read -p "Which folder colour do you want? " answer
if [[ "default,blue,green,grey,orange,pink,purple,red,yellow" == *$answer* ]]; then
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the user enters something like "grey,orange", then the script will look for files named "grey,orange*" and maybe crash.
If someone has a better idea to secure this, that would be cool.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a plan for this similar to how we do it for style, so don't worry about that :) Gonna basically move the /files/colours to / and then split the files by colour. Then the check will be the same as it is for style, that the colour selected has a folder existing.

@Foggalong
Copy link
Contributor

As far as I can tell, this is good to go! I'll make some modifications and clean it up to be consistent with the rest of the code, but congratulations: your implementations was a lot smarter than what I had in mind :P

Foggalong added a commit that referenced this pull request Apr 26, 2015
Allows user to choose the default colour
@Foggalong Foggalong merged commit 6d406c9 into numixproject:master Apr 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants