Skip to content

Fixing bad union corruption #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 11, 2025
Merged

Fixing bad union corruption #148

merged 2 commits into from
Sep 11, 2025
+7 −3

Conversation

SwayamInSync
Copy link
Member

Although it can done without this way, but still keeping it as I learn something new from it :)

@SwayamInSync SwayamInSync mentioned this pull request Sep 11, 2025
Merged
5 tasks
ngoldbaum
ngoldbaum approved these changes Sep 11, 2025
View reviewed changes
Copy link
Member

@ngoldbaum ngoldbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, casting to a union was wrong here. Sorry for missing when we first reviewed this code.

@SwayamInSync
Copy link
Member Author

Waiting on this PR to ensure every other build on conda-forge works with this new SDIST.
Once all good, will merge it then

@SwayamInSync
Copy link
Member Author

Merging it

@SwayamInSync SwayamInSync merged commit 4dd1dbe into numpy:main Sep 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngoldbaum ngoldbaum ngoldbaum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SwayamInSync @ngoldbaum