Skip to content

add asan to stringdtype build #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 30, 2023
Merged

add asan to stringdtype build #32

merged 3 commits into from
Jan 30, 2023

Conversation

ngoldbaum
Copy link
Member

This builds stringdtype with asan support. I also pass -s to pytest so pytest doesn't capture the output from asan when a test fails.

@ngoldbaum
Copy link
Member Author

Both python itself and stringdtype leak memory, so I'm turning off LeakSanitizer. In the future when we fix the memory leaks in stringdtype we can come back to this and add suppressions for the memory leaks in python.

@ngoldbaum
Copy link
Member Author

looks like it's working! https://github.com/numpy/numpy-user-dtypes/actions/runs/4027429067/jobs/6923148711

@ngoldbaum ngoldbaum merged commit 54ec4e1 into numpy:main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ngoldbaum