Apply NPY_DT_NUMERIC flag where appropriate #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the new
_is_numericattribute, in anticipation of further testing with pandas using the dtypes in this repo.There are some formatting changes to appease the pre-commit hooks, those shouldn't have functional changes. I also needed to fix how the black pre-commit hook is set up to work around psf/black#2863, otherwise black and ruff will get into a fight.
Unfortunately due to an oversight on my part this PR depends on numpy/numpy#23306 being merged before this can be merged.