Add argmax PyArray_ArrFunc
#47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peytondmurray
force-pushed
the
pyarray-arrfunc-argmax
branch
from
6812eea to
9b62415
Compare
ngoldbaum
reviewed
Mar 8, 2023
peytondmurray
force-pushed
the
pyarray-arrfunc-argmax
branch
2 times, most recently
from
3aefcab to
5c71053
Compare
|
I think the tests are failing because the numpy PR on which this PR depends was merged today, and hasn't yet been built in the nightly wheels. Local tests pass for me. |
|
Yeah, it is a little annoying we need to wait on that. We could bring back #4 and build numpy from source. Installing from the wheel was so much faster I dropped it. |
|
Ehh, let's just be patient. I hate waiting forever for CI to run, and this only comes up once in a while. |
|
Triggered a build. But maybe we should adjust the numpy |
peytondmurray
force-pushed
the
pyarray-arrfunc-argmax
branch
from
5c71053 to
cb10af0
Compare
|
Retriggered the CI, looks good now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
argmax. I've also modified the signature of thePyArray_CompareFuncto match the documentation. Additionally,compareis now safe against elements withNULLdata, e.g.x = np.empty(10); x.sort()is now safe.Finally, there was an issue with
isortin the pre-commit hooks. Autoupdating the hooks resolves this.