Make stringdtype parametric on na_object again #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngoldbaum
commented
Jul 12, 2023
| if (ssdup(s, os) < 0) { | ||
| gil_error(PyExc_MemoryError, "ssdup failed"); | ||
| return -1; | ||
| if (in != out) { |
There was a problem hiding this comment.
This extra check was needed for cases when we're casting from an array to a view of the same array and the views have the same starting location. In that case we don't need to copy at all and if we did we'd have a use-after-free. Tricky!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backs out #67.
While working on #76 I realized I'd need to make stringdtype parametric, so I had to look into whether the dtype being parametric is a showstopper. It turns out the original reason I made the dtype parametric was solved by #70, so there's no problem with making the dtype parametric.
Making the dtype parametric eliminates a ton of copy/paste code and eliminates the runtime dependency on pandas if pandas is installed.
I checked and all of the string dtype tests in pandas pass when I update my fork of pandas to reflect this change in stringdtype.