Skip to content

Fix display of ecosystem tab for Ja and Pt #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

melissawm
Copy link
Member

Brief description of what is fixed or changed

This restores the display of the Scientific Domains tab for Japanese and Portuguese. An update of how these tabs are pulled together was not applied to the translated pages which was causing the missing content.

Also updates the CSS for the tabs so that the scientific domain titles are correctly aligned.

Finally, there were some newlines applies to yaml files that are probably incorrect.

Copy link

netlify bot commented Sep 18, 2024

Deploy Preview for numpy-org ready!

Name Link
🔨 Latest commit 5684c64
🔍 Latest deploy log https://app.netlify.com/sites/numpy-org/deploys/66eb3b61a445620008319284
😎 Deploy Preview https://deploy-preview-784--numpy-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@melissawm
Copy link
Member Author

Copy link
Contributor

@steppi steppi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @melissawm. Looks good

@stefanv
Copy link
Contributor

stefanv commented Sep 18, 2024

Go ahead and merge when you're ready, @melissawm

steppi
steppi approved these changes Sep 18, 2024
@steppi steppi merged commit 9036567 into numpy:main Sep 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants